refactor: Move parsing of overlay ppa config to functions.#668
Draft
fnordahl wants to merge 2 commits intoopenstack-charmers:masterfrom
Draft
refactor: Move parsing of overlay ppa config to functions.#668fnordahl wants to merge 2 commits intoopenstack-charmers:masterfrom
fnordahl wants to merge 2 commits intoopenstack-charmers:masterfrom
Conversation
fnordahl
force-pushed
the
per-app-ppa
branch
3 times, most recently
from
a0db661 to
dfbc81d
Compare
The overlay ppa config has multiple uses, move parsing from the function that builds model-level cloud-init user data to separate functions. Signed-off-by: Frode Nordahl <fnordahl@ubuntu.com>
fnordahl
force-pushed
the
per-app-ppa
branch
2 times, most recently
from
8006786 to
2c5ce28
Compare
In some circumstances we want to install packages from overlay PPA on specific applications and not across the whole model. Add configuration grammar, actual implementation of generic setup step will follow in subsequent patch. Signed-off-by: Frode Nordahl <fnordahl@ubuntu.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The overlay ppa config has multiple uses, move parsing from the function that builds model-level cloud-init user data to separate functions.